Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chromium): roll Chromium to r800071 #6407

Merged
merged 1 commit into from Sep 9, 2020
Merged

feat(chromium): roll Chromium to r800071 #6407

merged 1 commit into from Sep 9, 2020

Conversation

sadym-chromium
Copy link
Collaborator

@sadym-chromium sadym-chromium commented Sep 9, 2020 •
edited

  • roll Chromium to version r800071, 86.0.4240.0
  • roll Chrome DevTools protocol version to 0.0.799653
  • fix HTTPRequest.continue
  • update new-docs

mathiasbynens
mathiasbynens approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Just a small nit: please follow the commit message format from other roll CLs, including linking to upstream Chromium CLs for each Puppeteer change — in this case, that's only 1 CL.

johanbay
johanbay reviewed Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@johanbay johanbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too 🙂

@sadym-chromium sadym-chromium changed the title Roll Chromium 86 #6376 feat(chromium): roll Chromium to r800071 Sep 9, 2020
@sadym-chromium
feat(chromium): roll Chromium to r800071
916a607 
* roll Chromium to version 86, r800071
* roll Chrome DevTools protocol version to 0.0.799653
* fix HTTPRequest.continue after
  * CDP: accept post data in the binary form in Fetch.continueRequest.
    https://chromium-review.googlesource.com/c/chromium/src/+/2315239
* update new-docs
@sadym-chromium sadym-chromium merged commit 62ac167 into puppeteer:main Sep 9, 2020
@mathiasbynens
Copy link
Member

Thanks!

Next time, please follow the same commit message format as other roll commits, including the full Chromium version number — it really helps when cutting releases.

@sadym-chromium sadym-chromium deleted the roll_chromium_86 branch September 11, 2020 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

@johanbay johanbay johanbay approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sadym-chromium @mathiasbynens @johanbay @googlebot