feat(page): emulate idle state #6410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* https://bugs.chromium.org/p/chromium/issues/detail?id=1090802 * added `page.setIdleOverride(...)`; * added `page.clearIdleOverride()`; * added tests; * added launch argument `--enable-blink-features=IdleDetection` to turn IdleDetection on.
sadym-chromium
requested review from
mathiasbynens,
OrKoN,
hanselfmu and
johanbay
mathiasbynens
previously requested changes
Sep 10, 2020
There was a problem hiding this comment.
The implementation LGTM. I left some comments mostly wanting to discuss the Puppeteer-level API. There is no need to match the CDP API directly — we should try to provide the most user-friendly API possible (which in most cases is somewhat different from the CDP one).
OrKoN
approved these changes
Sep 10, 2020
mathiasbynens
approved these changes
Sep 14, 2020
sadym-chromium
changed the title
Co-authored-by: Mathias Bynens <mathias@qiwi.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page.emulateIdleState(...)allowing emulate or remove emulation of the idle state;emulate idle->remove emulation->emulate idle->remove emulation;--enable-blink-features=IdleDetectionto turn IdleDetection on.