feat(coverage): option for raw V8 script coverage #6454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quramy
force-pushed
the
full-v8-coverage-result
branch
2 times, most recently
from
ca19cef
to
d083296
Compare
|
|
Quramy
force-pushed
the
full-v8-coverage-result
branch
from
d083296
to
ff16699
Compare
jackfranklin
approved these changes
Oct 2, 2020
|
@mathiasbynens @jackfranklin Can you please merge this? |
|
How about this? Let me know if anything needs to be fixed ! |
mathiasbynens
force-pushed
the
main
branch
4 times, most recently
from
03a4ca1
to
d4b17bd
Compare
jschfflr
approved these changes
Sep 11, 2021
This was referenced Feb 7, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
includeRawScriptCoverageoption to include full V8 precise coverage entry to result ofpage.coverage.stopJSCoverage()Motivation
It's related to issue #985 . I want to map Puppeteer's coverage result with source-map with https://github.com/istanbuljs/v8-to-istanbul . But The Puppeteer's coverage result's range objects are edited by
convertToDisjointRangesfunction and v8-to-istanbul can't map .So, I want this option to get V8 raw coverage result, whose functions' ranges are not joined.
[FYI] The similar method in Praywrite returns raw V8 coverage result. https://playwright.dev/#version=v1.4.2&path=docs%2Fapi.md&q=chromiumcoveragestopjscoverage