Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add iPhone 11 models to DeviceDescriptors #6467

Merged
merged 1 commit into from Jan 8, 2021

Conversation

yomed
Copy link
Contributor

@yomed yomed commented Oct 3, 2020

Hi, I noticed the latest iPhone models were missing. I got the width, height, deviceScaleFactor from this site: https://yesviz.com/devices.php

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@yomed
Copy link
Contributor Author

yomed commented Oct 3, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 3, 2020
Copy link

@whalderman whalderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if the userAgents need to be updated to the latest supported version. I know they aren't terribly important, so if up-to-date user agents are not necessary, this'll work fine.

@mathiasbynens mathiasbynens merged commit 50b810d into puppeteer:main Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants