New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add param threshold
to isIntersectingViewport
#6497
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
6f5ccfd
to
e118cd3
Compare
Since this is an API change, could you please add a test? |
I quite like this change. I wonder about the API being @mathiasbynens wdyt about this? |
Agreed on using an options bag. |
@mathiasbynens I add a unit test about isIntersectingViewport~Thanks |
I couldn't handle this pr,colud anyone please resolve the merging conflicts? @jackfranklin |
03a4ca1
to
d4b17bd
Compare
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
@ron0115 I went ahead and resolved the merge conflicts while also updating the implementation a bit. Let me know if you're ok with the changes and I'm happy to get this landed :) |
When I write an e2e test about controlling scrollbar, I found I got visibleRatio = 0.001xxxx,I must add a threshold to finish this judge in my situation. Looking forward to your comments