Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add param threshold to isIntersectingViewport #6497

Merged
merged 6 commits into from Sep 15, 2021
Merged

Conversation

ron0115
Copy link
Contributor

@ron0115 ron0115 commented Oct 9, 2020

When I write an e2e test about controlling scrollbar, I found I got visibleRatio = 0.001xxxx,I must add a threshold to finish this judge in my situation. Looking forward to your comments

@google-cla
Copy link

google-cla bot commented Oct 9, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 9, 2020
@ron0115
Copy link
Contributor Author

ron0115 commented Oct 9, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 9, 2020
@ron0115 ron0115 force-pushed the patch-1 branch 3 times, most recently from 6f5ccfd to e118cd3 Compare October 10, 2020 02:12
@mathiasbynens
Copy link
Member

Since this is an API change, could you please add a test?

@jackfranklin
Copy link
Collaborator

I quite like this change. I wonder about the API being { threshold: X } (so it's self-documenting & easy to add more options in future).

@mathiasbynens wdyt about this?

@mathiasbynens
Copy link
Member

Agreed on using an options bag.

@ron0115
Copy link
Contributor Author

ron0115 commented Oct 27, 2020

@mathiasbynens I add a unit test about isIntersectingViewport~Thanks

@ron0115
Copy link
Contributor Author

ron0115 commented Jan 6, 2021

I couldn't handle this pr,colud anyone please resolve the merging conflicts? @jackfranklin

@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 15, 2021
@jschfflr
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 15, 2021
@jschfflr
Copy link
Contributor

@ron0115 I went ahead and resolved the merge conflicts while also updating the implementation a bit. Let me know if you're ok with the changes and I'm happy to get this landed :)

@jschfflr jschfflr self-requested a review September 15, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants