Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use old utility world #6528

Merged
merged 1 commit into from Nov 26, 2020
Merged

Conversation

dmitrysteblyuk
Copy link
Contributor

It is being destroyed later when browser reconnects to the page (after page navigation).
See #6527

@google-cla
Copy link

google-cla bot commented Oct 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 20, 2020
@dmitrysteblyuk
Copy link
Contributor Author

@googlebot I signed it!

@dmitrysteblyuk
Copy link
Contributor Author

dmitrysteblyuk commented Oct 21, 2020

@jackfranklin sorry for the ping, but it seems like all recent builds (for last 4 different prs) are failing with the same pattern. No errors in console, just this

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Can someone please investigate this? 🙏

@jackfranklin
Copy link
Collaborator

@dmitrysteblyuk thanks for the ping, I'm investigating this now 👍

@jackfranklin
Copy link
Collaborator

@dmitrysteblyuk hey, I think that if you were to rebase your PR onto main again this would hopefully go green. Would you mind doing that? Thanks again and sorry for the Travis issues.

@mathiasbynens mathiasbynens merged commit fb85911 into puppeteer:main Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants