Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox version metadata download should respect HTTPS proxy config #6573

Closed
benelliott opened this issue Nov 2, 2020 · 3 comments
Closed

Comments

@benelliott
Copy link
Contributor

benelliott commented Nov 2, 2020

Steps to reproduce

Tell us about your environment:

  • Puppeteer version: 5.4.1
  • Platform / OS version: Windows 10
  • URLs (if applicable): N/A
  • Node.js version: 12.13.0

What steps will reproduce the problem?

Please include code that reproduces the issue.

  1. Use Puppeteer via a proxy
  2. Provide proxy config via HTTP_PROXY / HTTPS_PROXY env vars and proxy / https-proxy NPM config
  3. Set PUPPETEER_PRODUCT=firefox

What is the expected result?

Puppeteer's install.js should use the provided proxy config when downloading Firefox version metadata from https://product-details.mozilla.org/1.0/firefox_versions.json

What happens instead?

Download fails with ECONNREFUSED.

===

The problem is that in install.ts, proxy options are configured for the binary data download but not for the Firefox metadata download.

This can be done via the https-proxy-agent package which is already a dependency (used in BrowserFetcher.ts). I'll look at submitting a PR.

@gamma032steam
Copy link

For anyone interested, I ended up switching to Playwright in order to work around this.

@stale
Copy link

stale bot commented Jun 24, 2022

We're marking this issue as unconfirmed because it has not had recent activity and we weren't able to confirm it yet. It will be closed if no further activity occurs within the next 30 days.

@stale stale bot added the unconfirmed label Jun 24, 2022
@stale
Copy link

stale bot commented Jul 24, 2022

We are closing this issue. If the issue still persists in the latest version of Puppeteer, please reopen the issue and update the description. We will try our best to accomodate it!

@stale stale bot closed this as completed Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment