Aria queries combined with waitFor* throws unexpected error after page navigation

[kevin940726]

Steps to reproduce

Tell us about your environment:

• Puppeteer version: v5.5.0
• Platform / OS version: macOS v10.15.7
• URLs (if applicable): https://github.com/kevin940726/puppeteer-aria-query-bug
• Node.js version: 14.15.1

What steps will reproduce the problem?

Aria queries companied with waitFor will fail to query any elements after page navigation.

await page.waitForSelector('aria/Button[role="button"]'); // This is fine

await page.reload(); // Or any other page navigation

await page.waitForSelector('aria/Button[role="button"]'); // Cannot find the element anymore 💀 

I've put together a minimal repro repo to better demo the issue.

What is the expected result?

It should still successfully get the elements even after page navigation.

What happens instead?
It throws timeout error.

[mathiasbynens]

Jan, could you PTAL? I wonder if this could be a problem for recordings.

[jschfflr]

I can confirm the problem and will investigate!

[jschfflr]

Ok, so it looks like this boils down to the following problem:
v8 checks if a binding has already been installed before. With the current implementation this check returns true even after the reload but the binding will not be there anymore. It seems like there are two possible solutions in this case:

• Use the undocumented parameter executionContextName for Runtime.addBinding and set it to UTILITY_WORLD_NAME
• Fix the v8 implementation to either not add the name to the m_activeBindings Set if an executionContextId is set or to remove the name from the set when the execution context is deleted.

@mathiasbynens Let me know what you think would be the best option here!

[sunmasters]

Adding waitForTimeout after reload may work.

[silicakes]

It seems this reproduces in the following repo:
https://github.com/electricmonk/ts-react-tdd/runs/7185943119?check_suite_focus=true#step:12:63

It behaves the same locally and remotely and is flaky:

When headless is set to false we actually see the items, yet the selector still fails.