feat(chromium): roll Chromium to r843427

[sadym-chromium]

This corresponds to Chromium 89.0.4389.0
This roll includes:

• Add SameParty attribute to cookies (crrev.com/c/2598846)
• Anchor target=_blank implies rel=noopener (crrev.com/c/1630010)
• Don't expect ignored elements in the AXTree (crrev.com/c/2505362)

BREAKING CHANGE:

• page.$$ doesn't return skipped elements anymore.

[OrKoN]

why would not the old test work?

[sadym-chromium]

According to what I got from the CL 2643792, it used to cut the screenshot respecting the ViewPort position, but now the viewport moves to the clip first, and then taking screenshot. So the initial ViewPort offset doesn't matter anymore.
Actual output of the initial version of the test: https://i.imgur.com/QC2rTB5.png

[sadym-chromium]

Corresponding bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1164610

[mathiasbynens]

So this is a breaking change in how Puppeteer's clip works?

[sadym-chromium]

yes, it is.
Another breaking change is in the AriaQuery

[sadym-chromium]

Mentioned in the initial commit.

[sadym-chromium]

Oh, it's the breaking change in how the screenshot works. The clip is still respected in both offset and size. But the result screenshot is filled with white without respect of the initial ViewPort offset, only based on its size.

[sadym-chromium]

BTW, there are some problems with the respecting offset in the screenshot.
EG this example produces the incorrectly-looking result: https://i.imgur.com/syIImrg.png

await page.setViewport({ width: 50, height: 50 });
await page.goto(server.PREFIX + '/grid.html');
const screenshot = await page.screenshot({
  clip: {
    x: 25,
    y: 25,
    width: 100,
    height: 100,
  },
});

[mathiasbynens]

Okay, thanks. Btw, per https://www.conventionalcommits.org/en/v1.0.0/#summary we should use this format:

BREAKING CHANGE: …

[sadym-chromium]

Please update versions.js as well

done

[mathiasbynens]

So this is a breaking change in how Puppeteer's clip works?

[mathiasbynens]

LGTM % lint and other failing CI checks

[mathiasbynens]

As discussed offline, we should first roll to Chromium 89 and cut a Puppeteer release before landing this.

[sadym-chromium]

As discussed offline, we should first roll to Chromium 89 and cut a Puppeteer release before landing this.

All the breaking changes are the same, so I just updated the versions of this PR so that it rolls Chromium 89.