fix: explicit HTTPRequest.resourceType type defs #6882
Merged
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschfflr
reviewed
Feb 16, 2021
src/common/HTTPRequest.ts
Outdated
| * | ||
| * @public | ||
| */ | ||
| export type ResourceType = |
There was a problem hiding this comment.
In my local browser_protocol.pdl file, there are some more ResourceTypes:
- SignedExchange
- Ping
- CSPViolationReport
- Preflight
Is there a specific reason why they are not included here?
We can use the new `Lowercase` util in TS4 to avoid duplicating the type
and instead lowercase it.
Note we still need to do the work so callbacks are typed correctly:
```ts
page.on('request', request => {
})
```
Right now `request` is `any`, whereas it should be a
`puppeteer.HTTPRequest`. You can manually set the type for now, and I
will work on adding types for events so that this is done automatically
by the compiler in a future release.
Fixes #6854.
jackfranklin
force-pushed
the
http-request-resource-type
branch
from
1df3946
to
895a3aa
Compare
|
@jschfflr please take another look - I discovered the |
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6854.