Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aria): fix parsing of ARIA selectors #7037

Merged
merged 2 commits into from Apr 6, 2021
Merged

fix(aria): fix parsing of ARIA selectors #7037

merged 2 commits into from Apr 6, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Mar 30, 2021

  • adds a g flag so that the replacer is called for every match.
  • fixes the reported error message and adds a test.

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
mathiasbynens
mathiasbynens approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the linter seems unhappy

@OrKoN OrKoN merged commit 4426135 into main Apr 6, 2021
@OrKoN OrKoN deleted the fix-aria branch April 6, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathiasbynens mathiasbynens mathiasbynens approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OrKoN @mathiasbynens