Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

captureBeyondViewport as screenshot optinal param #7063

Merged
merged 9 commits into from Apr 6, 2021

Conversation

galr52
Copy link
Contributor

@galr52 galr52 commented Apr 6, 2021

making the captureBeyondViewport as an optional parameter to the screenshot

#7043

@google-cla
Copy link

google-cla bot commented Apr 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Apr 6, 2021
@galr52
Copy link
Contributor Author

galr52 commented Apr 6, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Apr 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 6, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@galr52
Copy link
Contributor Author

galr52 commented Apr 6, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 6, 2021
Copy link
Collaborator

@sadym-chromium sadym-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! One thing: if captureBeyondViewport: false is used, the screenshot beyond the viewport will be blank. The logic with Emulation.setDeviceMetricsOverride should be returned as well in case of captureBeyondViewport: false: https://github.com/puppeteer/puppeteer/pull/6805/files

@galr52
Copy link
Contributor Author

galr52 commented Apr 6, 2021

Thanks for the PR! One thing: if captureBeyondViewport: false is used, the screenshot beyond the viewport will be blank. The logic with Emulation.setDeviceMetricsOverride should be returned as well in case of captureBeyondViewport: false: https://github.com/puppeteer/puppeteer/pull/6805/files

i fixed your comment, i hope that i understand you correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants