Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chromium): roll to Chromium 91.0.4469.0 (r869685) #7110

Merged
merged 1 commit into from Apr 21, 2021
Merged

Conversation

sadym-chromium
Copy link
Collaborator

  • Roll to Chromium 91.0.4469.0 (r869685).
  • Update CONTRIBUTING.md.

@sadym-chromium sadym-chromium enabled auto-merge (squash) April 21, 2021 10:39
@sadym-chromium sadym-chromium merged commit 715e7a8 into main Apr 21, 2021
@sadym-chromium sadym-chromium deleted the roll91 branch April 21, 2021 10:43
@mathiasbynens mathiasbynens mentioned this pull request Apr 21, 2021
@lizhucheng
Copy link

why used Canary chromium version

@lostsource
Copy link

Doesn't look like this contains patch(s) for CVE-2021-21224 right?

http://crrev.com/869685 returns a commit from Apr 06 , while patches where submitted Apr 12 / 14

@sadym-chromium
Copy link
Collaborator Author

The release was cut a day before promoting 91 to Beta. It's still pointing to the latest build available for all 4 platforms (linux, mac, win32, win64).

You are right, the mentioned commits are not included in this version of Chrome.

Please justify the need of cutting another minor version including above commits.

@lostsource
Copy link

Well there are multiple use cases for Puppeteer, some of which might be running on public servers which are now susceptible to this attack.

Was trying to figure out which minor version from 91.x.x contains those fixes via omahaproxy but I got lost in the process.. 🤦‍♂️

@sadym-chromium
Copy link
Collaborator Author

Thanks for the heads-up! I will cut the new minor version once the corresponding build is available.

@sadym-chromium
Copy link
Collaborator Author

Heads-up: there is still no newer builds available. 869685 is the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants