feat: add more Android models to DeviceDescriptors #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds device descriptions for: * Galaxy S8 * Galaxy S9+ * Galaxy Tab S4 * Pixel 3 * Pixel 4 These devices are regarded as worthy of targeting by [BrowserStack](https://www.browserstack.com/test-on-the-right-mobile-devices). Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data
|
@mathiasbynens wdyt? |
|
I think the intention is to keep this in sync with the emulated devices in DevTools: https://source.chromium.org/chromium/chromium/src/+/main:third_party/devtools-frontend/src/front_end/panels/emulation/EmulatedDevices.ts;l=637-1368;drc=229a54f7ea0133738b1a6d395507dc80e4f18de8 I'm not opposed to landing this, but the way to do it would be to suggest the change as a DevTools patch before landing it here. Would you be up for that? |
|
@mathiasbynens, sounds good, I took a crack at it: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919612 |
mathiasbynens
force-pushed
the
main
branch
4 times, most recently
from
03a4ca1
to
d4b17bd
Compare
jschfflr
approved these changes
Sep 11, 2021
devtools-bot
pushed a commit
to ChromeDevTools/devtools-frontend
that referenced
this pull request
Sep 11, 2021
Adds: Galaxy S8 Galaxy S9+ Galaxy Tab S4 Pixel 3 Pixel 4 These devices are regarded as worthy of targeting by https://www.browserstack.com/test-on-the-right-mobile-devices Sources (both have identical data for these 5 devices): 1. https://github.com/aerokube/moon-deploy/blob/master/moon-local.yaml#L199 2. https://www.danhendricks.com/2018/04/adding-iphone-galaxy-chrome-mobile-emulated-devices/#heading_device_data The same changes (structured differently) have been added to Playwright ( microsoft/playwright#6413 ). This PR was suggested by @mathiasbynens, see puppeteer/puppeteer#7210 Change-Id: I70db28b15b77fcdb82171a08ebd0b33aa0886621 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2919612 Reviewed-by: Jan Scheffler <janscheffler@chromium.org> Reviewed-by: Changhao Han <changhaohan@chromium.org> Reviewed-by: Peter Müller <petermueller@chromium.org> Reviewed-by: Mraz Marian <mraz@chromium.org> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by: Paul Lewis <aerotwist@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
|
Thank you @jschfflr, for your help here and also in DevTools, very much appreciated! 🙏 |
|
@mrienstra Sure, happy to help! |
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds device descriptions for:
These devices are regarded as worthy of targeting by BrowserStack.
Sources (both have identical data for these 5 devices):