build: allow to customize tmpdir

[Kikobeats]

Hello,

This change allows customizing the directory for temporary files, setting up the current behavior as default.

I'm particularly interested in this change because I want to use a memory filesystem (memfs) to speed up a bit the puppeteer process.

[Kikobeats]

hum checks are failing for a non related thing.

[mathiasbynens]

The option is named tmpdir but it should be tmpDir to match the casing convention.

If we want to do this then introducing an environment variable like PUPPETEER_TMP_DIR seems like a cleaner option.

The patch would also need to include a test and the relevant changes to documentation. WDYT?

[Kikobeats]

ops, fixed the camel case naming 🙂

I'm not sure about PUPPETEER_TMP_DIR because it's limiting the possibility to use a function where the path can change over time, rather than a static string.

[mathiasbynens]

I'm not sure about PUPPETEER_TMP_DIR because it's limiting the possibility to use a function where the path can change over time, rather than a static string.

If the path changes over time and your code knows about it, can't you have it update the PUPPETEER_TMP_DIR env var accordingly?

[Kikobeats]

you're right; I'm assuming os.tmpdir() will return a different path every time, but it looks like constant value:

let me do the code changes for a new environment variable 🙂

[Kikobeats]

@mathiasbynens done at 083ea5f

Do you think it could be moved into a common, so it just could be declared once?

[Kikobeats]

@mathiasbynens Can I do something to move this PR forward? 🙂

[mathiasbynens]

The diff seems to include lots of unrelated changes. Could you please check?

[Kikobeats]

@mathiasbynens updated 👍

[Kikobeats]

@mathiasbynens all green now 🙂

[jschfflr]

Could you maybe move the implementation of const tmpDir = () => process.env.PUPPETEER_TMP_DIR || os.tmpdir(); into a separate file like helpers.ts or something similar to reduce code duplication?

[Kikobeats]

Could you maybe move the implementation of const tmpDir = () => process.env.PUPPETEER_TMP_DIR || os.tmpdir(); into a separate file like helpers.ts or something similar to reduce code duplication?

I want to do that, experimental/puppeteer-firefox/lib/Launcher.js is CJS and src/node/Launcher.ts is ESM.

I guess I can't just create a file that can be loaded on both parts; am I wrong?

[jschfflr]

Could you maybe move the implementation of const tmpDir = () => process.env.PUPPETEER_TMP_DIR || os.tmpdir(); into a separate file like helpers.ts or something similar to reduce code duplication?

I want to do that, experimental/puppeteer-firefox/lib/Launcher.js is CJS and src/node/Launcher.ts is ESM.

I guess I can't just create a file that can be loaded on both parts; am I wrong?

Ah sorry, I didn't see that one is for Firefox and one in src. In this case, I think this change looks good!

[Kikobeats]

@jschfflr @mathiasbynens any chance to merge this? it's already approved and tests pass on green 🙂