Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extend husky checks #7574

Merged
merged 2 commits into from Sep 20, 2021
Merged

feat: extend husky checks #7574

merged 2 commits into from Sep 20, 2021

Conversation

jschfflr
Copy link
Contributor

I added some more checks to huskys config to because not addressing them leads to a bunch of unnecessary cycles for reviews and CI and the overhead for the developer seems rather small. Let me know what you think!

Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mathiasbynens
Copy link
Member

Let's give this a try! (We can use git commit --no-verify git push --no-verify to skip the hooks, which I've never had to do before, but might start doing occasionally with this change.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants