Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(page): expose page.client() #7582

Merged
merged 1 commit into from
Sep 21, 2021
Merged

feat(page): expose page.client() #7582

merged 1 commit into from
Sep 21, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 20, 2021

Puppeteer already allows creating a new CDP session
via target.createCDPSession but there is no way
to get access to any existing session to send
some additional commands.

Copy link
Member

@mathiasbynens mathiasbynens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please add a test

Puppeteer already allows creating a new CDP session
via target.createCDPSession but there is no way
to get access to any existing session to send
some additional commands.
@OrKoN OrKoN enabled auto-merge (squash) September 21, 2021 07:24
@OrKoN OrKoN merged commit 99ca842 into main Sep 21, 2021
@OrKoN OrKoN deleted the page-client branch September 21, 2021 07:39
@jschfflr
Copy link
Contributor

@OrKoN I think we should mark this as @internal as we have a bunch of internal assumptions about the state the connection is in. Our documentation recommends users to create a new CDP session instead.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Sep 21, 2021

Oh, I didn't know. Where is it documented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants