Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should HTTPRequest's interceptResolution be public? #7745

Closed
Tyler-Murphy opened this issue Nov 4, 2021 · 1 comment · Fixed by #7813
Closed

Should HTTPRequest's interceptResolution be public? #7745

Tyler-Murphy opened this issue Nov 4, 2021 · 1 comment · Fixed by #7813

Comments

@Tyler-Murphy
Copy link

puppeteer/src/common/HTTPRequest.ts

Line 208 in 07febca

private interceptResolution(): [InterceptResolutionStrategy, number?] {

api.md makes it sound like it should be public, and I'd like to be able to use it so I can decide whether to act on a request or not, based on its resolution.
@Tyler-Murphy Tyler-Murphy mentioned this issue Nov 29, 2021
Merged
@benallfree benallfree mentioned this issue Nov 29, 2021
Merged
@benallfree
Copy link
Contributor

Fixed in #7813

OrKoN pushed a commit that referenced this issue Dec 9, 2021
@benallfree @FdezRomero
fix!: typo in 'already-handled' constant of the request interception …
8242422 
…API (#7813)

Issues:  #7745, #7747, #7780
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: already-handled spelling [v13] benallfree/puppeteer
2 participants
@benallfree @Tyler-Murphy