Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in InterceptResolutionStrategy #7747

Closed
Tyler-Murphy opened this issue Nov 4, 2021 · 2 comments
Closed

Typo in InterceptResolutionStrategy #7747

Tyler-Murphy opened this issue Nov 4, 2021 · 2 comments

Comments

@Tyler-Murphy
Copy link

Tyler-Murphy commented Nov 4, 2021 •
edited

puppeteer/src/common/HTTPRequest.ts

Line 210 in 07febca

if (this._interceptionHandled) return ['alreay-handled'];

I think it should be already-handled.

Because there must be code out there that relies on this typo, I think this'll need to be a major version bump.
@harshagrawal523
Copy link

I tried changing it , please let me know is this is correct?

#7780

@Tyler-Murphy Tyler-Murphy mentioned this issue Nov 29, 2021
Merged
@benallfree benallfree mentioned this issue Nov 29, 2021
Merged
@benallfree
Copy link
Contributor

Fix in #7813

OrKoN pushed a commit that referenced this issue Dec 9, 2021
@benallfree @FdezRomero
fix!: typo in 'already-handled' constant of the request interception …
8242422 
…API (#7813)

Issues:  #7745, #7747, #7780
Co-authored-by: Rodrigo Fernández <fdez.romero@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@benallfree @Tyler-Murphy @harshagrawal523