[Regression]: page.waitForFunction passes an unexpected first argument to pageFunction since Puppeteer 13

[timvandermeij]

Bug description

For Mozilla's PDF.js we use Puppeteer for our integration tests. The upgrade from Puppeteer 12.0.1 to 13.0.0 made one test fail and investigation showed that there is a regression in Puppeteer 13.

Steps to reproduce the problem:

1. Install Puppeteer 12.0.1 with npm.
2. Create a file called repro.js with the following minimal reproducer:

const puppeteer = require("puppeteer");
const dns = require("dns");

dns.setDefaultResultOrder("ipv4first");

async function reproduce() {
  const browser = await puppeteer.launch({
    product: "chrome",
    headless: false,
  });
  const page = await browser.newPage();
  await page.goto("https://nodejs.org/en/docs/");

  try {
    const selector = "body";
    await page.waitForFunction(
      (_selector) => document.querySelector(_selector) !== null,
      {},
      selector,
    );
  } catch (ex) {
    console.log(ex);
  }
  await browser.close();
}

reproduce();

2. Run node repro.js and notice no errors being logged (browser starts and no output is logged). This is expected.
3. Install Puppeteer 13.0.0 with npm.
4. Run node repro.js and and notice that it fails all of a sudden, with the following logged exception:

Error: Evaluation failed: DOMException: Failed to execute 'querySelector' on 'Document': '[object HTMLDocument]' is not a valid selector.
    at eval (eval at waitForPredicatePageFunction (:3:23), <anonymous>:3:33)
    at eval (eval at waitForPredicatePageFunction (:3:23), <anonymous>:3:67)
    at onRaf (__puppeteer_evaluation_script__:50:35)
    at pollRaf (__puppeteer_evaluation_script__:43:15)
    at waitForPredicatePageFunction (__puppeteer_evaluation_script__:8:22)
    at ExecutionContext._evaluateInternal (/home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer/lib/cjs/puppeteer/common/ExecutionContext.js:221:19)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async WaitTask.rerun (/home/timvandermeij/Documenten/Ontwikkeling/pdf.js/Code/node_modules/puppeteer/lib/cjs/puppeteer/common/DOMWorld.js:547:27)

This is unexpected because nothing in the changelogs indicates a change in behavior here. Moreover, the API documentation at https://github.com/puppeteer/puppeteer/blob/main/docs/api.md#pagewaitforfunctionpagefunction-options-args clearly states, and even includes an example of, that pageFunction only gets the arguments we give it.

However, in Puppeteer 13 I found after debugging all of a sudden the first argument to pageFunction is the document object for some reason, and the other arguments are shifted, so the second argument is what used to be the first one in Puppeteer 12.0.1, et cetera. This is why it fails: the document.querySelector call gets the document object as argument now since Puppeteer 13 put that inside the _selector argument.

Note that this happens in both Chrome and Firefox, so it's not browser-specific.

Puppeteer version

13.0.0

Node.js version

17.1.0

npm version

8.1.3

What operating system are you seeing the problem on?

Linux

Relevant log output

(see above)

[simonhammes]

I am also experiencing a similar issue (trying to upgrade puppeteer to v13): GitHub Action Run

Element .edit-post-more-menu [aria-label="Options"] not found
Evaluation failed: DOMException: Failed to execute 'querySelectorAll' on 'Document': '[object HTMLDocument]' is not a valid selector.

[campersau]

Looks like #7825 is now passing in the root as the first parameter to the predicate e.g. here

puppeteer/src/common/DOMWorld.ts

Line 930 in a3d2300

const success = await predicate(root, ...args);

puppeteer/src/common/DOMWorld.ts

Line 940 in 3e3a90b

const success = await predicate(root, ...args);

puppeteer/src/common/DOMWorld.ts

Line 965 in 3e3a90b

const success = await predicate(root, ...args);

puppeteer/src/common/DOMWorld.ts

Line 982 in 3e3a90b

const success = await predicate(root, ...args);

[neonidian]

I am also experiencing a similar issue (trying to upgrade puppeteer to v13): GitHub Action Run

Element .edit-post-more-menu [aria-label="Options"] not found
Evaluation failed: DOMException: Failed to execute 'querySelectorAll' on 'Document': '[object HTMLDocument]' is not a valid selector.

+1
Experiencing the same issue on upgrade to Puppeteer version 13. Had to revert back to version 12.

[OrKoN]

Thanks for the report, I will take a look soon.

[timvandermeij]

Closing since this should be fixed by #7845 now and therefore hopefully part of a new release soon. Thanks @OrKoN for fixing this!

[slawiko]

@timvandermeij is there any ETA for release of this fix? By coincidence our project needs both fixes: this one and the one from 13.0.0 :)
UPD:
I see 13.0.1 released. Thanks a lot!