Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure ElementHandle.waitForSelector is evaluated in the right context #7843

Merged
merged 1 commit into from Dec 21, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 14, 2021

So it appears that all bindings are added to the secondary world and all
evaluations are also running there. ElementHandle.evaluate is returning
handles from the main world though. Therefore, we need to be careful
and adopt handles to the right context before evaluating within
waitForSelector.

@OrKoN OrKoN force-pushed the waitForSelector-fixContext branch 2 times, most recently from 5ae5376 to d95087f Compare December 15, 2021 09:00
@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 15, 2021

Updated the PR and moved the adoption of the context element to the top-level so that no internals have to be changed: the root ElementHandle will be already in the same context.

…t context

So it appears that all bindings are added to the secondary world and all
evaluations are also running there. ElementHandle.evaluate is returning
handles from the main world though. Therefore, we need to be careful
and adopt handles to the right context before doing waitForSelector
So it appears that all bindings are added to the secondary world and all
evaluations are also running there. ElementHandle.evaluate is returning
handles from the main world though. Therefore, we need to be careful
and adopt handles to the right context before doing waitForSelector..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants