Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable a test failing on Firefox #7846

Merged
merged 1 commit into from Dec 15, 2021
Merged

fix: disable a test failing on Firefox #7846

merged 1 commit into from Dec 15, 2021

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Dec 14, 2021

No description provided.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 14, 2021

@whimboo @mathiasbynens it looks like one test started to fail in Firefox. Should I just disable it for now?

@OrKoN OrKoN merged commit 36207c5 into main Dec 15, 2021
@OrKoN OrKoN deleted the fix-firefox-test branch December 15, 2021 08:17
@whimboo
Copy link
Collaborator

whimboo commented Dec 15, 2021

@whimboo @mathiasbynens it looks like one test started to fail in Firefox. Should I just disable it for now?

Nothing has changed on our side. @OrKoN, do you have the exact failure details? I don't see any at https://github.com/puppeteer/puppeteer/commits/main. Thanks.

@OrKoN
Copy link
Collaborator Author

OrKoN commented Dec 15, 2021

@whimboo yes, here is the failure https://github.com/puppeteer/puppeteer/runs/4526884428?check_suite_focus=true (it's on this PR, before I added itFailsOnFirefox, so it includes the main + a newline change; originally started failing in another PR I wanted to submit).

@whimboo
Copy link
Collaborator

whimboo commented Dec 15, 2021

Strange. We don't see that in our own CI which runs the tests on Linux. But we still haven't caught up downstream syncs for a while. Right now @juliandescottes work on syncing to v13.0.0. Maybe it brings up this problem for us... Thanks for notifying us!

@juliandescottes
Copy link
Contributor

juliandescottes commented Dec 15, 2021

I haven't seen this particular test fail with the 13.0.0 sync. A disconnected browser when navigating to an image sounds like it might be site-isolation (fission) related? and could possibly behave differently depending in the OS?

Edit: In the logs I also see that we fail on the assert Execution Context has already been set. added by #7722 . So if that's the root cause of the failure, and if this is intermittent, it makes sense we haven't seen it yet on our CI, because this is not in the version of puppeteer we have currently vendored (v10.0.0). I'm running more tests with v13.0.0 at the moment, I'll let you know if I see the test fail on our CI as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants