New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable a test failing on Firefox #7846
Conversation
31c2bdc
to
f956f9e
Compare
f956f9e
to
3a9a2aa
Compare
@whimboo @mathiasbynens it looks like one test started to fail in Firefox. Should I just disable it for now? |
Nothing has changed on our side. @OrKoN, do you have the exact failure details? I don't see any at https://github.com/puppeteer/puppeteer/commits/main. Thanks. |
@whimboo yes, here is the failure https://github.com/puppeteer/puppeteer/runs/4526884428?check_suite_focus=true (it's on this PR, before I added itFailsOnFirefox, so it includes the main + a newline change; originally started failing in another PR I wanted to submit). |
Strange. We don't see that in our own CI which runs the tests on Linux. But we still haven't caught up downstream syncs for a while. Right now @juliandescottes work on syncing to v13.0.0. Maybe it brings up this problem for us... Thanks for notifying us! |
I haven't seen this particular test fail with the 13.0.0 sync. A disconnected browser when navigating to an image sounds like it might be site-isolation (fission) related? and could possibly behave differently depending in the OS? Edit: In the logs I also see that we fail on the assert |
No description provided.