fix: error for pre-existing OOPIFs #7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
fix-error-for-existing-oopifs
branch
from
512b37c
to
d4de4c8
Compare
mathiasbynens
approved these changes
Jan 14, 2022
|
Does this need a test? |
|
I have not figured out if we can connect to an existing browser instance in Puppeteer tests? I think it'd be good to add a test if I can find a straightforward way. In general, this should have been a type error in TS. |
|
Figured out a test, PTAL |
OrKoN
force-pushed
the
fix-error-for-existing-oopifs
branch
from
d4de4c8
to
adab250
Compare
OrKoN
force-pushed
the
fix-error-for-existing-oopifs
branch
from
adab250
to
1ac1132
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: #7844, #7896