Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly compute clickable points for elements inside OOPIFs #7900

Merged
merged 1 commit into from Jan 17, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Jan 14, 2022

Issues: #7849

@OrKoN OrKoN force-pushed the fix-clickable-coordinates-for-oopifs branch from b9cf8a6 to 90e2853 Compare January 14, 2022 14:14
@OrKoN OrKoN force-pushed the fix-clickable-coordinates-for-oopifs branch from 90e2853 to 72720e2 Compare January 14, 2022 14:30
@Mr0grog
Copy link

Mr0grog commented Jan 14, 2022

I think this needs to be handled in ElementHandle._getBoxModel(), too, since I was also encountering the issue with .boxModel() and .boundingBox() (which both use it), and it’s a totally separate code path from ElementHandle.clickablePoint().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants