Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more models to DeviceDescriptors #7904

Merged
merged 4 commits into from Feb 2, 2022
Merged

feat: add more models to DeviceDescriptors #7904

merged 4 commits into from Feb 2, 2022

Conversation

nswbmw
Copy link
Contributor

@nswbmw nswbmw commented Jan 16, 2022

  • iPad (gen 6)
  • iPad (gen 7)
  • iPad Pro 11
  • iPhone 12
  • iPhone 12 Pro
  • iPhone 12 Pro Max
  • iPhone 12 Mini
  • iPhone 13
  • iPhone 13 Pro
  • iPhone 13 Pro Max
  • iPhone 13 Mini
  • Pixel 4a (5G)
  • Pixel 5
  • Moto G4

Sync from playwright

@johanbay johanbay self-requested a review January 21, 2022 08:48
Copy link
Collaborator

@johanbay johanbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! The changes to DeviceDescriptors look good to me, but please revert the LICENSE file before we can merge.

LICENSE Outdated Show resolved Hide resolved
Copy link
Collaborator

@johanbay johanbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants