[Bug]: Error [ERR_PACKAGE_PATH_NOT_EXPORTED]:

[rmarkins-godaddy]

Bug description

Steps to reproduce the problem:

1. Install latest puppeteer-core
2. attempt to path to ./lib/cjs/puppeteer/revisions

Puppeteer version

13.3.0

Node.js version

14.19.0

npm version

6.14.19

What operating system are you seeing the problem on?

Linux, macOS

Relevant log output

Full error


internal/modules/cjs/loader.js:456
      throw e;
      ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './lib/cjs/puppeteer/revisions' is not defined by "exports" in /Users/rmarkins/dev/work/ghc/support/estimo/node_modules/puppeteer-core/package.json
    at new NodeError (internal/errors.js:322:7)
    at throwExportsNotFound (internal/modules/esm/resolve.js:332:9)
    at packageExportsResolve (internal/modules/esm/resolve.js:565:3)
    at resolveExports (internal/modules/cjs/loader.js:450:36)
    at Function.Module._findPath (internal/modules/cjs/loader.js:490:31)
    at Function.Module._resolveFilename (internal/modules/cjs/loader.js:888:27)
    at Function.Module._load (internal/modules/cjs/loader.js:746:27)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at require (internal/modules/cjs/helpers.js:101:18)
    at Object.<anonymous> (/Users/rmarkins/dev/work/ghc/support/estimo/scripts/find-chrome-binary.js:6:33) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

[rmarkins-godaddy]

You can see an example of this for require in https://github.com/mbalabash/estimo/blob/master/scripts/find-chrome-binary.js#L6

This affects those using @size-limit/time package.

Subsequently is it possible just to add those to the exports path as it is useful information. Happy to open a PR w/ a fix if that's agreeable.

[OrKoN]

Ugh, sorry about that. We didn't realise that the internal modules were used directly. Let's see how we can fix it (happy to review a PR) but my first thought is: perhaps we should create an API for this use case?

[jan-molak]

@OrKoN an API or a dedicated export would be appreciated, thanks! We're seeing the same issue with WebdriverIO (and other frameworks that rely on it, like Serenity/JS), which relies on Puppeteer to run local tests. Here are the puppeteer-core imports WebdriverIO uses.

Perhaps they could be added to exports?

[OrKoN]

we are going to export everything by default like it was (#7991 and #7992 should solve the issue)

[OrKoN]

Change of plans: we are going to revert the change and re-land it later in a backwards-compatible way.

[rmarkins-godaddy]

closing as solved in 13.3.1. Thanks for the quick turnaround