fix: element screenshot issue in headful mode #8018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
d38b47a
to
52074e4
Compare
src/common/JSHandle.ts
Outdated
| // Fallback to `layoutViewport` in case of using Firefox. | ||
| const { pageX, pageY } = | ||
| layoutMetrics.cssLayoutViewport || layoutMetrics.layoutViewport; | ||
| const { pageX, pageY } = layoutMetrics.layoutViewport; |
There was a problem hiding this comment.
As a temp workaround we can get the cssPixel / deprecatedPixel ratio and normalize the layoutViewport.pageX, layoutViewport.pageY by that ratio.
There was a problem hiding this comment.
smth like
const pixelRatio = layoutMetrics.cssLayoutViewport.clientWidth / layoutMetrics.layoutViewport.clientWidth;
There was a problem hiding this comment.
Actually, according to the implementation, it looks like we have to use cssVisualViewport instead. DevTools uses it and screenshots in Canary DevTools works well.
My experiment showed the cssLayoutViewport.Page[X/Y] shows the window's position on the screen.
There was a problem hiding this comment.
Suggested change
| const { pageX, pageY } = layoutMetrics.layoutViewport; | |
| const { pageX, pageY } = layoutMetrics.cssVisualViewport; |
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
52074e4
to
24b2347
Compare
OrKoN
changed the title
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
24b2347
to
4e65f34
Compare
sadym-chromium
approved these changes
Feb 15, 2022
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
4e65f34
to
4572e9a
Compare
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
4572e9a
to
d8a1ade
Compare
OrKoN
force-pushed
the
fix-screenshots-node
branch
from
d8a1ade
to
fa8e5e2
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7999