fix: ensure dom binding is not called after detach

[pmmmwh]

What kind of change does this PR introduce?

bug fix

Did you add tests for your changes?

Yes

No, but can add if deemed necessary

If relevant, did you update the documentation?

No

Summary

Fixes #7814

Functions exposed via page.exposeFunction are not unbind when a frame is detached, which in turn causes the error regarding missing execution context being raised.

puppeteer/src/common/DOMWorld.ts

Lines 153 to 159 in 1d6c82b

	executionContext(): Promise<ExecutionContext> {
	if (this._detached)
	throw new Error(
	`Execution context is not available in detached frame "${this._frame.url()}" (are you trying to evaluate?)`
	);
	return this._contextPromise;
	}

This PR adds _detached as a criterion to _hasContext, indicating there is no context available, causing _onBindCalled to exit early. An alternative solution could be to remove all Runtime.bindingCalled listeners on the client when detaching, which will stop events from firing completely.

puppeteer/src/common/DOMWorld.ts

Lines 114 to 116 in 1d6c82b

	this._client.on('Runtime.bindingCalled', (event) =>
	this._onBindingCalled(event)
	);

Does this PR introduce a breaking change?

No

Other information

First started happening in 11.0.0, still reproducible in the latest release.
Tested on Node.js 14.x and 16.x.

[OrKoN]

Would it be much more difficult to implement the alternative solution? Also, I think it'd be really great to have a test for this.

[OrKoN]

Thanks a lot. Looks good, I just added a suggestion to fix the test.