Ensure all tests honour the BINARY envvar. #8092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NightTsarina
force-pushed
the
pr/tests-use-BINARY
branch
from
fc2fb14
to
20c597c
Compare
OrKoN
force-pushed
the
pr/tests-use-BINARY
branch
from
20c597c
to
e3409f1
Compare
OrKoN
approved these changes
Mar 3, 2022
Without this patch, two tests ignore the BINARY envvar, and fail when not using the embedded chromium, unless the chromium executable path is defined via PUPPETEER_EXECUTABLE_PATH, which should not be considered according to the docs.
OrKoN
force-pushed
the
pr/tests-use-BINARY
branch
from
e3409f1
to
b7847cf
Compare
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, two tests ignore the BINARY envvar, and fail when not using the embedded chromium, unless the chromium executable path is defined via PUPPETEER_EXECUTABLE_PATH, which should not be considered according to the docs.