Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chromium downloading hung at 99% #8169

Merged
merged 1 commit into from Mar 31, 2022
Merged

fix: chromium downloading hung at 99% #8169

merged 1 commit into from Mar 31, 2022

Conversation

0xGaryWu
Copy link
Contributor

bugfix: #5048

@google-cla
Copy link

google-cla bot commented Mar 28, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@0xGaryWu 0xGaryWu changed the title fix issues: 5048, chromium downloading hung 99% fix: chromium downloading hung at 99% Mar 28, 2022
@0xGaryWu
Copy link
Contributor Author

checks failing is not my reason, how to fix it to work well

@OrKoN
Copy link
Collaborator

OrKoN commented Mar 30, 2022

It looks like the type Options does not support headers. See https://github.com/puppeteer/puppeteer/runs/5750713940?check_suite_focus=true#step:4:61

set keep-alive header to fix downloading done without 'finish' event trigged on some devices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants