Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: respond multiple headers with same key #8183

Merged
merged 1 commit into from Apr 5, 2022

Conversation

Junyan
Copy link
Contributor

@Junyan Junyan commented Apr 2, 2022

What kind of change does this PR introduce?

Fix issue #5740

Update headers option of HTTP.respond(), support multiple headers with same key.

Did you add tests for your changes?

  • Yes

If relevant, did you update the documentation?

  • Yes

Summary

In HTTP response header, set-cookie will occur repeatedly when there are multiple cookie names.

image

Does this PR introduce a breaking change?

  • Yes, array of header value will not convert to a string.

@Junyan Junyan force-pushed the feat-respond-multiple-header-key branch from 5cf4eb2 to c96310d Compare April 2, 2022 15:54
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants