fix: ignore favicon requests in page.spec event handler tests #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliandescottes
force-pushed
the
fix-6020
branch
from
db534af
to
3f76e14
Compare
|
cc @OrKoN for review :) |
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6020
Favicon requests are automatically triggered when loading empty.html (except on chrome headless) and make the tests fail intermittently.
In this patch, I define a custom response handler which ignores specifically the favicon requests. I prefer this rather than "only consider requests to empty.html" because it feels more conservative, and should not hide potential future regressions.
Alternatively, we could use a different test page than empty.html, eg called
no-favicon.htmlwhich would simply containLet me know which approach you prefer.