Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support chrome headless mode #8260

Merged
merged 4 commits into from Apr 25, 2022
Merged

feat: support chrome headless mode #8260

merged 4 commits into from Apr 25, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Apr 21, 2022

Issues: #8173

@OrKoN OrKoN force-pushed the chrome-headless branch 3 times, most recently from 4d27a16 to 3438a55 Compare April 22, 2022 10:43
@OrKoN OrKoN requested a review from ergunsh April 22, 2022 11:00
Copy link
Collaborator

@ergunsh ergunsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments

docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
docs/api.md Outdated Show resolved Hide resolved
OrKoN and others added 4 commits April 25, 2022 11:40
Co-authored-by: Ergün Erdoğmuş <erdogmusergun@gmail.com>
Co-authored-by: Ergün Erdoğmuş <erdogmusergun@gmail.com>
@OrKoN OrKoN merged commit 1308d9a into main Apr 25, 2022
@OrKoN OrKoN deleted the chrome-headless branch April 25, 2022 11:11
kzar added a commit to kzar/duckduckgo-privacy-extension that referenced this pull request May 7, 2022
Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260
kzar added a commit to kzar/duckduckgo-privacy-extension that referenced this pull request May 9, 2022
Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260
kzar added a commit to kzar/duckduckgo-privacy-extension that referenced this pull request May 11, 2022
Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260
jonathanKingston pushed a commit to duckduckgo/duckduckgo-privacy-extension that referenced this pull request May 12, 2022
Puppeteer recently added headless support for running Chrome
extensions[1], so let's make use of that. Also, let's take care to
properly wait for the extension's background page to load.

1 - puppeteer/puppeteer#8260
This was referenced May 30, 2022
This was referenced May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants