fix: disable AvoidUnnecessaryBeforeUnloadCheckSync to fix navigations #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
speculative-fix-for-headful
branch
2 times, most recently
from
ebbf76b
to
335fd6d
Compare
OrKoN
changed the title
OrKoN
force-pushed
the
speculative-fix-for-headful
branch
from
335fd6d
to
b905393
Compare
ergunsh
approved these changes
May 11, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced May 30, 2022
This was referenced Jun 13, 2022
paulirish
reviewed
Nov 9, 2022
Comment on lines
+217
to
+218
| // TODO: remove AvoidUnnecessaryBeforeUnloadCheckSync below | ||
| // once crbug.com/1324138 is fixed and released. |
There was a problem hiding this comment.
Coming across this randomly. As this shipped in May I imagine it can be removed now?
I'm not in any rush. Just trying to be helpful. :)
There was a problem hiding this comment.
Removed in #9239 thanks for the ping!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.