Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use strict typescript #8401

Merged
merged 6 commits into from May 31, 2022
Merged

feat: use strict typescript #8401

merged 6 commits into from May 31, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented May 25, 2022 •
edited by OrKoN

Issues: #6769

@jrandolf jrandolf requested a review from OrKoN May 25, 2022 20:37
OrKoN
OrKoN requested changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the installation tests are failing. Let's separate package.json and dependency updates into a separate CL and also split the code changes into multiple CLs for easier review.

@jrandolf jrandolf force-pushed the strict-typescript branch 2 times, most recently from 879b89a to 5268be4 Compare May 30, 2022 12:58
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/Browser.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/DOMWorld.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/FrameManager.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/JSHandle.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/JSHandle.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/JSHandle.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/JSHandle.ts Outdated Show resolved Hide resolved
OrKoN
OrKoN reviewed May 30, 2022
View reviewed changes
src/common/JSHandle.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf force-pushed the strict-typescript branch 6 times, most recently from f52b8c1 to 7a9daaf Compare May 30, 2022 19:42
@jrandolf jrandolf force-pushed the strict-typescript branch 2 times, most recently from b76f50a to 7cf6cdc Compare May 31, 2022 11:22
OrKoN
OrKoN reviewed May 31, 2022
View reviewed changes
src/common/FrameManager.ts Outdated Show resolved Hide resolved
@jrandolf jrandolf merged commit b4e751f into main May 31, 2022
@jrandolf jrandolf deleted the strict-typescript branch May 31, 2022 14:34
This was referenced May 31, 2022
Closed
Closed
Closed
Merged
This was referenced Jun 13, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrandolf @OrKoN