Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support node 18 #8447

Merged
merged 1 commit into from Jun 1, 2022
Merged

feat: support node 18 #8447

merged 1 commit into from Jun 1, 2022

Conversation

jrandolf
Copy link
Contributor

@jrandolf jrandolf commented May 31, 2022

This CL patches some files to fully support Node 18.

@whimboo
Copy link
Collaborator

whimboo commented May 31, 2022

Please note that with node.js 17.0 the DNS resolution has been changed to default to IPv6 instead of IPv4. This could cause problems for users on dual-stack systems. For Firefox we have https://bugzilla.mozilla.org/show_bug.cgi?id=1769994 on file to get a better support. But not sure if Chrome might also be affected.

@jrandolf jrandolf force-pushed the support_node_18 branch 2 times, most recently from 9c7e1a6 to 2562aba Compare May 31, 2022 19:59
src/node/NodeWebSocketTransport.ts Outdated Show resolved Hide resolved
src/node/NodeWebSocketTransport.ts Outdated Show resolved Hide resolved
src/node/NodeWebSocketTransport.ts Outdated Show resolved Hide resolved
src/node/NodeWebSocketTransport.ts Outdated Show resolved Hide resolved
src/node/NodeWebSocketTransport.ts Show resolved Hide resolved
@jrandolf
Copy link
Contributor Author

jrandolf commented Jun 1, 2022

@whimboo @OrKoN I realized that I needed to submit my comments for you to see them... thanks @OrKoN....

@jrandolf jrandolf force-pushed the support_node_18 branch 3 times, most recently from 5ee5c29 to 90b6a47 Compare June 1, 2022 11:29
@OrKoN OrKoN enabled auto-merge (squash) June 1, 2022 11:33
@whimboo
Copy link
Collaborator

whimboo commented Jun 1, 2022

@jrandolf maybe you can give a quick feedback on how this would work on a IPv6 only system? Would it still work in case of Chrome?

@jrandolf
Copy link
Contributor Author

jrandolf commented Jun 1, 2022

@jrandolf maybe you can give a quick feedback on how this would work on a IPv6 only system? Would it still work in case of Chrome?

The implementation basically hardcodes the previous behavior, so however Node handled IPv6 systems before, the current behavior is the same.

Specifically, the resolver just has preference for IPv4, but if it cannot resolve IPv4, it resolves to an IPv6 address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants