New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support node 18 #8447
feat: support node 18 #8447
Conversation
Please note that with node.js 17.0 the DNS resolution has been changed to default to IPv6 instead of IPv4. This could cause problems for users on dual-stack systems. For Firefox we have https://bugzilla.mozilla.org/show_bug.cgi?id=1769994 on file to get a better support. But not sure if Chrome might also be affected. |
9c7e1a6
to
2562aba
Compare
5ee5c29
to
90b6a47
Compare
@jrandolf maybe you can give a quick feedback on how this would work on a IPv6 only system? Would it still work in case of Chrome? |
The implementation basically hardcodes the previous behavior, so however Node handled IPv6 systems before, the current behavior is the same. Specifically, the resolver just has preference for IPv4, but if it cannot resolve IPv4, it resolves to an IPv6 address. |
This CL patches some files to fully support Node 18.