fix: don't throw on bad access #8472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
commented
Jun 3, 2022
jrandolf
force-pushed
the
fix_8470
branch
3 times, most recently
from
e35e997
to
ce142ed
Compare
OrKoN
reviewed
Jun 7, 2022
jrandolf
force-pushed
the
fix_8470
branch
4 times, most recently
from
a44233a
to
61a6485
Compare
OrKoN
approved these changes
Jun 7, 2022
jrandolf
force-pushed
the
fix_8470
branch
2 times, most recently
from
64338e9
to
9bc41f1
Compare
This was referenced Jun 9, 2022
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a throw clause that is invalid when a script is run locally and connected remotely.
Fixes: #8470