fix: Kill browser process when killing process group fails #8477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes puppeteer#8476. Similar fix to puppeteer#8352 which only covered Windows.
Kikobeats
reviewed
Jun 7, 2022
| @@ -195,15 +195,23 @@ export class BrowserRunner { | |||
| if (error) { | |||
| // taskkill can fail to kill the process e.g. due to missing permissions. | |||
| // Let's kill the process via Node API. This delays killing of all child | |||
| // proccesses of `this.proc` until the main Node.js process dies. | |||
| // processes of `this.proc` until the main Node.js process dies. | |||
| proc.kill(); | |||
There was a problem hiding this comment.
@jimmydief is SIGKILL missing there in an intentional way?
There was a problem hiding this comment.
@Kikobeats I had wondered the same. FYI @szuend who made the original change in #8352.
There was a problem hiding this comment.
SIGKILL is not a thing on windows. So if I remember the Node.js documentation correctly a call to kill without any signal is equivalent to SIGKILL.
There was a problem hiding this comment.
oh, thanks for clarifying.
I considered the kill logic enough important to be alive as a separate package:
http://npm.im/kill-process-group
I was wondering if puppeteer will accept it if I send a PR; happy to invite anyone interested as contributor of the repo.
This was referenced Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
Did you add tests for your changes?
I did not add any – seems like this area is missing tests in general. I'm having trouble finding a simplified reproduction of this outside of my private project.
If relevant, did you update the documentation?
N/A
Summary
Fixes #8476 which seems to have been a regression from #6859. Similar fix to #8352 which only covered Windows.
Does this PR introduce a breaking change?
No.
Other information