fix: use error-like #8504
Merged
fix: use error-like #8504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
approved these changes
Jun 10, 2022
|
Thanks @jrandolf! |
This was referenced Jun 13, 2022
jimmydief
added a commit
to jimmydief/puppeteer
that referenced
this pull request
Jun 16, 2022
puppeteer#8497 does not seem to have been fully resolved for me with 14.4.0 (puppeteer#8504), likely because the `instanceof` check being changed in this PR also causes issues in Jest due to jestjs/jest#2549. I was able to confirm that this change avoids the error I've been seeing in CI by testing this change via `patch-package`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8497