fix: infer unioned handles #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
reviewed
Jun 24, 2022
OrKoN
reviewed
Jun 24, 2022
| ...args: EvaluateParams<Params> | ||
| ): Promise<Awaited<ReturnType<Func>>> { | ||
| ...args: Params | ||
| ): // @ts-expect-error Circularity here is okay because we only need the return |
There was a problem hiding this comment.
having test types would be nice at this point? does TS generate proper d.ts if there are some errors?
There was a problem hiding this comment.
Yes, it still generates the types correctly. I assume this would break if the type is truly circular (meaning it returns this somehow). Regarding testing this, the test files that changed at the tests in some sense. The typing on the files that changed broke as soon as I implemented this, which makes sense because they were wrong before.
OrKoN
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #8558