fix!: internalize execution context #8844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
jrandolf/r2-2-3
branch
from
051b7a4
to
9e9d8ff
Compare
OrKoN
approved these changes
Aug 25, 2022
jrandolf
force-pushed
the
jrandolf/r2-2-2
branch
from
d6b5e3b
to
aa45e11
Compare
jrandolf
force-pushed
the
jrandolf/r2-2-3
branch
from
9e9d8ff
to
09c3360
Compare
jrandolf
force-pushed
the
jrandolf/r2-2-3
branch
from
09c3360
to
bddda4b
Compare
This was referenced Aug 31, 2022
|
Is there more context regarding this change? Seems like this breaks packages like |
|
@swissspidy ExecutionContext API is a bit too broad and we want to make it internal to allow some future features. It looks like for these libraries getting the frame from the ElementHandle would work as well. Let me see if I can open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.