Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore deferred promise debugging #8895

Merged
merged 2 commits into from Sep 5, 2022
Merged

fix: restore deferred promise debugging #8895

merged 2 commits into from Sep 5, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 2, 2022

Closes #8832

@OrKoN OrKoN requested a review from jrandolf September 2, 2022 16:31
@OrKoN OrKoN marked this pull request as ready for review September 2, 2022 16:31
@OrKoN OrKoN requested review from sadym-chromium and removed request for jrandolf September 5, 2022 06:22
Copy link
Collaborator

@sadym-chromium sadym-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor comment

src/util/DebuggableDeferredPromise.ts Show resolved Hide resolved
@OrKoN OrKoN merged commit 7b42250 into main Sep 5, 2022
@OrKoN OrKoN deleted the fix-debuggable-promise branch September 5, 2022 08:30
OrKoN added a commit that referenced this pull request Sep 5, 2022
* fix: restore deferred promise debugging

* chore: strict types
OrKoN added a commit that referenced this pull request Sep 5, 2022
* fix: restore deferred promise debugging

* chore: strict types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Waiting for target frame x failed" when crawling a lot of websites concurrently
2 participants