[Bug]: page.#timeoutSettings is not accessible anymore

[GuillaumeGomez]

Bug description

I used to rely on page._timeoutSettings but it was turned into a private field when upgrading my puppeteer version. Would it be possible to add a getter so I can still get it? I can even make a PR for it if you want.

Thanks in advance!

Puppeteer version

17.1.1

Node.js version

v14.19.3

npm version

6.14.17

What operating system are you seeing the problem on?

Linux, macOS, Windows

Relevant log output

No response

[OrKoN]

Thanks for opening the issue! We were not aware that someone relies on it. Could you please share the use case for getting access to #timeoutSettings? Do you intend to only read existing values or mutate them too?

[GuillaumeGomez]

Only reading. My use case is as follow: I need to check multiple attributes (either property, CSS value, attribute) which prevent me from simply relying on puppeteer's page.waitFor* functions . However, I still want to keep the same timeout set by the user.

You can see my use case here.

[OrKoN]

So adding the following getter to the Page would be sufficient?

getDefaultTimeout(): number {
    return this.#timeoutSettings.timeout();
}

[GuillaumeGomez]

Absolutely!

[OrKoN]

Sounds good then. I am happy to review a PR or I could add it in the coming days.

[GuillaumeGomez]

Sending a PR right away then. Thanks for the quick replies!