Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Page.getDefaultTimeout getter #8903

Merged
merged 2 commits into from Sep 5, 2022

Conversation

GuillaumeGomez
Copy link
Contributor

Fixes #8901.

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@GuillaumeGomez GuillaumeGomez changed the title Add Page.getDefaultTimeout getter to return current Page default timeout Add Page.getDefaultTimeout getter to return current Page default timeout Sep 5, 2022
@OrKoN
Copy link
Collaborator

OrKoN commented Sep 5, 2022

You'd need to run npm run docs locally to regenerate markdown docs, and commit them or the check jobs will complain

@GuillaumeGomez
Copy link
Contributor Author

Done as well.

@OrKoN OrKoN enabled auto-merge (squash) September 5, 2022 16:52
@OrKoN OrKoN added the automerge label Sep 5, 2022
@OrKoN OrKoN disabled auto-merge September 5, 2022 16:53
@OrKoN OrKoN changed the title Add Page.getDefaultTimeout getter to return current Page default timeout fix: add Page.getDefaultTimeout getter Sep 5, 2022
@OrKoN OrKoN enabled auto-merge (squash) September 5, 2022 16:54
@OrKoN OrKoN merged commit 3240095 into puppeteer:main Sep 5, 2022
@GuillaumeGomez GuillaumeGomez deleted the page-default-timeout-getter branch September 5, 2022 17:48
@GuillaumeGomez
Copy link
Contributor Author

Thanks for the quick review and your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: page.#timeoutSettings is not accessible anymore
2 participants