Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't detect project root for puppeteer-core #8907

Merged
merged 1 commit into from Sep 6, 2022
Merged

fix: don't detect project root for puppeteer-core #8907

merged 1 commit into from Sep 6, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 6, 2022

Closes #8896

@OrKoN OrKoN requested a review from thiagowfx September 6, 2022 12:21
@OrKoN OrKoN merged commit b4f5ea1 into main Sep 6, 2022
@OrKoN OrKoN deleted the fixed-/8896 branch September 6, 2022 12:26
@release-please release-please bot mentioned this pull request Sep 6, 2022
Merged
@christian-bromann christian-bromann mentioned this pull request Sep 8, 2022
Closed
@christian-bromann
Copy link
Contributor

@OrKoN this has caused a regression, see #8919

@jtymes jtymes mentioned this pull request Sep 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagowfx thiagowfx thiagowfx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: puppeteer-core trying to load package.json "Cannot find package directory"
3 participants
@OrKoN @christian-bromann @thiagowfx