Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FirefoxLauncher should not use BrowserFetcher in puppeteer-core #8920

Merged
merged 2 commits into from Sep 8, 2022

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Sep 8, 2022

Closes #8919

@OrKoN OrKoN force-pushed the fixed-8919 branch 4 times, most recently from dca838d to b2d9c56 Compare September 8, 2022 08:42
@OrKoN OrKoN changed the title fix: puppeteer-core should not require project root fix: FirefoxLauncher should not use BrowserFetcher in puppeteer-core Sep 8, 2022
@OrKoN OrKoN marked this pull request as ready for review September 8, 2022 08:44
@OrKoN OrKoN requested a review from thiagowfx September 8, 2022 08:44
scripts/test-install.sh Outdated Show resolved Hide resolved
@OrKoN OrKoN enabled auto-merge (squash) September 8, 2022 08:51
@OrKoN OrKoN merged commit f2e8de7 into main Sep 8, 2022
@OrKoN OrKoN deleted the fixed-8919 branch September 8, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants