fix: use win64 version of chromium when on arm64 windows #8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm getting some unrelated failed checks, and don't see a way to re-run them. Can I get some help? |
|
Are win64 binaries executable on arm64 windows? |
good catch, only as of Windows 11. I'll add that check |
|
should be good now |
OrKoN
reviewed
Sep 13, 2022
no Win_arm available on storage.googleapis.com yet, and it currently defaults to win32
OrKoN
approved these changes
Sep 19, 2022
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
not relavant
If relevant, did you update the documentation?
not relavant
Summary
no Win_arm available on storage.googleapis.com yet, and it currently defaults to win32
Does this PR introduce a breaking change?
nope
Other information