feat: separate puppeteer and puppeteer-core #9023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf
force-pushed
the
monorepo-2
branch
9 times, most recently
from
3b82d31
to
759f4da
Compare
jrandolf
force-pushed
the
monorepo-2
branch
11 times, most recently
from
546b9a8
to
4d35735
Compare
|
I suspect Alex might have opinions on this. I’ll RLGTM this for now but please do address his feedback, if any, after landing! |
mathiasbynens
approved these changes
Sep 29, 2022
jrandolf
force-pushed
the
monorepo-2
branch
3 times, most recently
from
3ddb0b4
to
95d7412
Compare
jrandolf
force-pushed
the
monorepo-2
branch
from
95d7412
to
8061fd1
Compare
jrandolf
force-pushed
the
monorepo-2
branch
18 times, most recently
from
42d3761
to
58f22cc
Compare
OrKoN
approved these changes
Oct 5, 2022
This was referenced Oct 5, 2022
Closed
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the puppeteer source code into separate monorepo packages:
puppeteerandpuppeteer-coreare now separated into their own packages.puppeteer-corehas a new exports calledpuppeteer-core/internalfor internal usage.Tests and various tools have been updated to accommodate the migration.