From c37bad701aae32aa4c07738f20f6f30dd3bc2b22 Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Mon, 27 Apr 2020 10:07:48 +0100 Subject: [PATCH 1/5] chore: split out CI into unit tests + extra checks --- .travis.yml | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index b521994099a89..23ce9bd221fa4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,7 @@ services: xvfb jobs: include: + # Runs unit tests on OSX + Chromium - os: "osx" node_js: "10.19.0" env: @@ -15,6 +16,7 @@ jobs: - npm run tsc - npm run unit + # Runs unit tests on Windows + Chromium - os: "windows" node_js: "10.19.0" env: @@ -26,6 +28,7 @@ jobs: - npm run tsc - travis_retry npm run unit + # Runs unit tests on Linux + Chromium - node_js: "10.19.0" env: - CHROMIUM=true @@ -33,7 +36,19 @@ jobs: - PUPPETEER_PRODUCT=firefox npm install script: - npm run test-install - - travis/chromium.sh + - npm run coverage + + # This bot runs all the extra checks that aren't the main Puppeteer unit tests + - node_js: "10.19.0" + env: + -CHROMIUM=true + script: + - npm run test-install + - npm run lint + - npm run test-doclint + - npm run test-types + + # Runs unit tests on Linux + Firefox - node_js: "10.19.0" env: - FIREFOX=true From 51447de886f3e717625008bfea3d381062a678b4 Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Mon, 27 Apr 2020 10:29:52 +0100 Subject: [PATCH 2/5] names --- .travis.yml | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 23ce9bd221fa4..a10ec83510fd2 100644 --- a/.travis.yml +++ b/.travis.yml @@ -3,9 +3,8 @@ services: xvfb jobs: include: - - # Runs unit tests on OSX + Chromium - os: "osx" + name: 'Unit tests: OSX/Chromium' node_js: "10.19.0" env: - CHROMIUM=true @@ -16,8 +15,9 @@ jobs: - npm run tsc - npm run unit - # Runs unit tests on Windows + Chromium - os: "windows" + name: 'Unit tests: Windows/Chromium' + node_js: "10.19.0" node_js: "10.19.0" env: - CHROMIUM=true @@ -30,6 +30,7 @@ jobs: # Runs unit tests on Linux + Chromium - node_js: "10.19.0" + name: 'Unit tests: Linux/Chromium' env: - CHROMIUM=true before_install: @@ -40,6 +41,7 @@ jobs: # This bot runs all the extra checks that aren't the main Puppeteer unit tests - node_js: "10.19.0" + name: 'Extra tests: Linux/Chromium' env: -CHROMIUM=true script: @@ -50,6 +52,7 @@ jobs: # Runs unit tests on Linux + Firefox - node_js: "10.19.0" + name: 'Unit tests: Linux/Firefox' env: - FIREFOX=true before_install: From e90f008a4abdc0b83d829c5e87ae9b624e74fb7c Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Mon, 27 Apr 2020 11:30:50 +0200 Subject: [PATCH 3/5] Update .travis.yml --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index a10ec83510fd2..2d56e492b6ac3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,7 +4,7 @@ services: xvfb jobs: include: - os: "osx" - name: 'Unit tests: OSX/Chromium' + name: 'Unit tests: macOS/Chromium' node_js: "10.19.0" env: - CHROMIUM=true From fa71335c21cf810d812b621c1a2a3b15b1df4708 Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Mon, 27 Apr 2020 11:31:34 +0200 Subject: [PATCH 4/5] Update .travis.yml --- .travis.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 2d56e492b6ac3..d4bfd4f7e3272 100644 --- a/.travis.yml +++ b/.travis.yml @@ -18,7 +18,6 @@ jobs: - os: "windows" name: 'Unit tests: Windows/Chromium' node_js: "10.19.0" - node_js: "10.19.0" env: - CHROMIUM=true before_install: From 448169bb5a73fd6395a9507b13737747a7edd04d Mon Sep 17 00:00:00 2001 From: Mathias Bynens Date: Mon, 27 Apr 2020 11:31:54 +0200 Subject: [PATCH 5/5] Update .travis.yml --- .travis.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index d4bfd4f7e3272..3d5a1663af2c5 100644 --- a/.travis.yml +++ b/.travis.yml @@ -42,7 +42,7 @@ jobs: - node_js: "10.19.0" name: 'Extra tests: Linux/Chromium' env: - -CHROMIUM=true + - CHROMIUM=true script: - npm run test-install - npm run lint