From e7c92ca876d0b2f808bbf3fa5c6103e619dfb076 Mon Sep 17 00:00:00 2001 From: Changhao Han Date: Fri, 10 Jul 2020 12:50:22 +0200 Subject: [PATCH 1/4] feat(chromium): roll Chromium to r768783 --- src/revisions.ts | 2 +- utils/check_availability.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/revisions.ts b/src/revisions.ts index 9b307e9dca682..00166b52a2193 100644 --- a/src/revisions.ts +++ b/src/revisions.ts @@ -20,6 +20,6 @@ type Revisions = Readonly<{ }>; export const PUPPETEER_REVISIONS: Revisions = { - chromium: '756035', + chromium: '768783', firefox: 'latest', }; diff --git a/utils/check_availability.js b/utils/check_availability.js index 1a5f2cab49d84..86e2f034ebcde 100755 --- a/utils/check_availability.js +++ b/utils/check_availability.js @@ -17,7 +17,8 @@ const assert = require('assert'); const https = require('https'); -const BrowserFetcher = require('../lib/BrowserFetcher').BrowserFetcher; +// run `npm run dev-install` if lib dir is missing +const BrowserFetcher = require('../lib/cjs/node/BrowserFetcher').BrowserFetcher; const SUPPORTER_PLATFORMS = ['linux', 'mac', 'win32', 'win64']; const fetchers = SUPPORTER_PLATFORMS.map( From 5d9c4f55cecf720fb73a54ae035293e2a1db8038 Mon Sep 17 00:00:00 2001 From: Changhao Han Date: Fri, 10 Jul 2020 13:39:22 +0200 Subject: [PATCH 2/4] fix: update unit test for crrev:2135046 --- test/cookies.spec.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/cookies.spec.ts b/test/cookies.spec.ts index e2c41f2b94722..d5d60afd23d49 100644 --- a/test/cookies.spec.ts +++ b/test/cookies.spec.ts @@ -384,7 +384,7 @@ describe('Cookie specs', () => { }, ]); }); - itFailsFirefox('should set cookies from a frame', async () => { + it.only('should set cookies from a frame', async () => { const { page, server } = getTestState(); await page.goto(server.PREFIX + '/grid.html'); @@ -406,7 +406,9 @@ describe('Cookie specs', () => { expect(await page.evaluate('document.cookie')).toBe( 'localhost-cookie=best' ); - expect(await page.frames()[1].evaluate('document.cookie')).toBe(''); + expect(await page.frames()[1].evaluate('document.cookie')).toBe( + '127-cookie=worst' + ); expect(await page.cookies()).toEqual([ { From 8e777dce63cc9a23a39c0009e793a7c10389319e Mon Sep 17 00:00:00 2001 From: Changhao Han Date: Fri, 10 Jul 2020 13:47:24 +0200 Subject: [PATCH 3/4] fix: remove .only in unit test --- test/cookies.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/cookies.spec.ts b/test/cookies.spec.ts index d5d60afd23d49..ea840fe76ca2d 100644 --- a/test/cookies.spec.ts +++ b/test/cookies.spec.ts @@ -384,7 +384,7 @@ describe('Cookie specs', () => { }, ]); }); - it.only('should set cookies from a frame', async () => { + itFailsFirefox('should set cookies from a frame', async () => { const { page, server } = getTestState(); await page.goto(server.PREFIX + '/grid.html'); From cd0936497963f6c0f30c873a04c594d1419b689b Mon Sep 17 00:00:00 2001 From: Changhao Han Date: Fri, 10 Jul 2020 14:59:20 +0200 Subject: [PATCH 4/4] chore: update devtools-protocol revision --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index f0101afc7559f..c71db76f93f6a 100644 --- a/package.json +++ b/package.json @@ -45,7 +45,7 @@ "license": "Apache-2.0", "dependencies": { "debug": "^4.1.0", - "devtools-protocol": "0.0.754670", + "devtools-protocol": "0.0.767361", "extract-zip": "^2.0.0", "https-proxy-agent": "^4.0.0", "mime": "^2.0.3",